Skip to content

Conversation

VinciGit00
Copy link
Collaborator

Main differences:

Uploading Screenshot 2025-01-12 alle 16.27.18.png…
Screenshot 2025-01-12 alle 16 27 28

@VinciGit00 VinciGit00 linked an issue Jan 12, 2025 that may be closed by this pull request
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 12, 2025
Copy link

github-actions bot commented Jan 12, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
pip/myst-parser >= 2.0.0 🟢 4.6
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Code-Review⚠️ 2Found 7/26 approved changesets -- score normalized to 2
Maintained🟢 67 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 6
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/sphinx >= 7.1.2 🟢 5.4
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 18 issue activity found in the last 90 days -- score normalized to 10
Code-Review⚠️ 1Found 3/29 approved changesets -- score normalized to 1
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 1SAST tool is not run on all commits -- score normalized to 1
Vulnerabilities🟢 82 existing vulnerabilities detected
pip/sphinx-autoapi >= 3.0.0 🟢 4.6
Details
CheckScoreReason
Maintained🟢 1017 commit(s) and 5 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Code-Review⚠️ 2Found 7/30 approved changesets -- score normalized to 2
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ 11 out of the last 5 releases have a total of 1 signed artifacts.
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Packaging🟢 10packaging workflow detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/sphinx-autodoc-typehints >= 1.25.2 🟢 6.1
Details
CheckScoreReason
Code-Review🟢 4Found 5/11 approved changesets -- score normalized to 4
Maintained🟢 1016 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Packaging🟢 10packaging workflow detected
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/sphinx-copybutton >= 0.5.2 🟢 3.3
Details
CheckScoreReason
Code-Review🟢 5Found 8/16 approved changesets -- score normalized to 5
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies⚠️ 1dependency not pinned by hash detected -- score normalized to 1
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy⚠️ 0security policy file not detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Packaging⚠️ -1packaging workflow not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 010 existing vulnerabilities detected
pip/sphinx-design >= 0.5.0 🟢 3.9
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Code-Review⚠️ 2Found 8/28 approved changesets -- score normalized to 2
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Packaging⚠️ -1packaging workflow not detected
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 91 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/sphinx-rtd-theme >= 1.3.0 🟢 4
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 104 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 6Found 20/30 approved changesets -- score normalized to 6
Token-Permissions⚠️ -1No tokens found
Dangerous-Workflow⚠️ -1no workflows found
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 041 existing vulnerabilities detected
pip/duckduckgo-search >= 7.2.1 🟢 4.4
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 6 issue activity found in the last 90 days -- score normalized to 10
Code-Review⚠️ 0Found 0/22 approved changesets -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • docs/requirements-dev.txt
  • pyproject.toml

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 12, 2025
Copy link
Contributor

codebeaver-ai bot commented Jan 12, 2025

I added some Unit Tests (average coverage improvement: +33.04%). Check it out here to merge it!

Copy link
Contributor

codebeaver-ai bot commented Jan 12, 2025

No files changed in the PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 12, 2025
@VinciGit00
Copy link
Collaborator Author

I also run pre commit on the whole dir for

Copy link
Contributor

codebeaver-ai bot commented Jan 12, 2025

I added some Unit Tests (average coverage improvement: +50.00%). Check it out here to merge it!

@silgon
Copy link

silgon commented Jan 12, 2025

I'm just wondering, is there a reason not to use keyword arguments?
I believe you could have more understandable code, or at least not as many if elses as in the following picture.
image
The example would be:

def search_on_web(
    query: str,
    search_engine: str = "Google",
    max_results: int = 10,
    port: int = 8080,
    timeout: int = 10,
    proxy: str | dict = None,
    serper_api_key: str = None,
    **kwargs
) -> List[str]:
...
 google_search(
                        query,
                        num_results=max_results,
                        proxy=formatted_proxy,
                        **kwargs
                    )

You probably have a reason, you can just ignore this comment in any case. Thx again for the great package =)

@VinciGit00
Copy link
Collaborator Author

This is the definition fo the search function from google_search library.

As you can see is not present the default region

Screenshot 2025-01-12 alle 19 39 37

Copy link
Contributor

codebeaver-ai bot commented Jan 12, 2025

I added some Unit Tests (average coverage improvement: +50.00%). Check it out here to merge it!

@silgon
Copy link

silgon commented Jan 12, 2025

I see what you mean @VinciGit00 , however if your parameters are in the dictionary of parameters, there are going to be filled with the ** operator. Example:

def display_info(name, age):
    print(f"Name: {name}, Age: {age}")

person_info = {
    'name': 'Alice',
    'age': 30
}

display_info(**person_info)

@VinciGit00
Copy link
Collaborator Author

@silgon take a look now

Copy link
Contributor

codebeaver-ai bot commented Jan 12, 2025

I added some Unit Tests (average coverage improvement: +50.00%). Check it out here to merge it!

@silgon
Copy link

silgon commented Jan 12, 2025

Nice! 😎

@VinciGit00 VinciGit00 requested a review from PeriniM January 13, 2025 11:30
Copy link
Contributor

codebeaver-ai bot commented Jan 17, 2025

Job has been stopped

Copy link
Contributor

codebeaver-ai bot commented Jan 17, 2025

No tests were needed for this PR, I think. If you were expecting tests, check out the documentation here to fix the issue

Copy link
Contributor

codebeaver-ai bot commented Jan 17, 2025

No tests were needed for this PR, I think. If you were expecting tests, check out the documentation here to fix the issue

@VinciGit00
Copy link
Collaborator Author

@PeriniM I removed google search paragraph because it was not working anymore, probably due to new google policies

Copy link
Contributor

codebeaver-ai bot commented Jan 20, 2025

No tests were needed for this PR, I think. If you were expecting tests, check out the documentation here to fix the issue

Copy link

🎉 This PR is included in version 1.36.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

codebeaver-ai bot commented Jan 21, 2025

No tests were needed for this PR, I think. If you were expecting tests, check out the documentation here to fix the issue

@VinciGit00 VinciGit00 merged commit b3aa03e into main Jan 21, 2025
6 checks passed
@VinciGit00 VinciGit00 deleted the 829-languagecountry-selection branch January 21, 2025 20:17
Copy link

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @dev released on @stable size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language/Country selection
3 participants